_SelfUpdate() - Update the running executable.

[Exit]

Restart does not honor commandline options.

[guinness]

In my humble opinion this function shouldn't honour that. If the user wants to pass commandline parameters then this is down to them, plus this function should be called towards the end of the applications life.

Edited November 9, 2012 by guinness

[Exit]

Same issue as in your _SelfRename() UDF

[guinness]

That function should be called at the start of the script, hence why I added commandline support. But _SelfUpdate should be called at the end of an application and thus I see no reason to add this. Unless you can come up with some good reason.

[hutchinsfairy]

I am using _SelfUpdate and for my purposes it makes more sense to silently update itself from a network drive before doing anything else.

I have also adapted your UDF so that the new update file is copied rather than moved. This means the update file is still available for other users on the domain to update from.

Also a couple of possible typos:

1) Should

$sDelay = 'IF %TIMER% GTR ' & $iDelay & ' GOTO DELETE'

actually be

$sDelay = 'IF %TIMER% GTR ' & $iDelay & ' GOTO MOVE'

2) Some backslashes missing in paths (I think this might be a feature of pasting code into the forum)

[guinness]

Improved source code layout and did away with the horrendous magic numbers.

[michaelslamet]

Hi guinness,

This SelfUpdate function works great for GUI application, but when we try to self update a CUI application:

1. The batch file will be shown on screen (could be hide with @echo off)

2. at the end running the batch file, it will display message "the batch file cannot be found." and then pause. I found how to get rid of this message, but the challenge is:

1. make sure the old_version.exe and new_version.exe display message on the same cmd window (new_version.exe should not open a new cmd window to display messages)

2. back to command prompt directly after running the new_version.exe, make sure it has no pause at the end. Pause is happening when the batch file delete itself.

Should be no pause because pause will cause problem on a auto running CUI application that run through scheduler on a headless machine.

Do you have idea how to solve this?

Thanks, guinness

; new_version.au3 ==> new_version.exe
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_UseUpx=n
#AutoIt3Wrapper_Change2CUI=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****

ConsoleWrite("version 2" & @CRLF)

 

; old_version.au3 ==> old_version.exe

#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_UseUpx=n
#AutoIt3Wrapper_Change2CUI=y
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <Constants.au3>
#include '_SelfUpdate.au3'

; Start the SelfUpdate batch file with a 30 second timer, using the process name rather than the PID and restart the application after updating.
_SelfUpdate(@ScriptDir & '\new_version.exe', True, 5, False)
If @error Then
    Exit ConsoleWrite("The script must be a compiled exe to work correctly or the update file must exist." & @CRLF)
EndIf

ConsoleWrite("version 1" & @CRLF)

[guinness]

I will have a look on the weekend. Remind me if I don't get back to you please.

[michaelslamet]

I will have a look on the weekend. Remind me if I don't get back to you please.

 

Thanks a lot, Sir

[guinness]

OK. I hope you will try and debug as well because it shouldn't make any difference.

[michaelslamet]

OK. I hope you will try and debug as well because it shouldn't make any difference.

 

Yes, I will

The worst can happen is I will do a auto update just for a GUI application, but for CUI, it will exit after download the new version (if available)

[guinness]

Well it works for me, the only issue I see is the batch file is displayed in the console window. Is that your issue? If so check the new version in the first post. If not then explain more clearly please.

[michaelslamet]

Well it works for me, the only issue I see is the batch file is displayed in the console window. Is that your issue? If so check the new version in the first post. If not then explain more clearly please.

 

I understand that batch file command can be hide using @echo off, but that is not the issue.

Here I attached the screenshot.

The issue are:

1. it doesn't auto start (restart) the new version, or maybe yes but it display the message (consolewrite) on the new cmd window that closed after the new_version.exe exit

2. when finish it will display message "The batch file cannot be found" and then PAUSE. We need to remove the pause or simulate a ENTER key to it.

Here is my post previously:

1. make sure the old_version.exe and new_version.exe display message on the same cmd window (new_version.exe should not open a new cmd window to display messages)

2. back to command prompt directly after running the new_version.exe, make sure it has no pause at the end. Pause is happening when the batch file delete itself.

Should be no pause because pause will cause problem on a auto running CUI application that run through scheduler on a headless machine.

Thanks

Edit: attached the screenshot

Edited November 1, 2013 by michaelslamet

[guinness]

I can't replicate your issue(s). Sorry.

[michaelslamet]

I can't replicate your issue(s). Sorry.

 

Did you compile it as CUI application and run it through DOS prompt?

#AutoIt3Wrapper_Change2CUI=y

[guinness]

I compiled as a CUI, but didn't run through a DOS prompt. Just selected the exe file via double-click.

[michaelslamet]

I compiled as a CUI, but didn't run through a DOS prompt. Just selected the exe file via double-click.

 

Do you mind to see how it's going if we run it through a DOS prompt?

Because that is the way I try it

[guinness]

I will again this weekend. But I can't see how it would be any different.

[DatMCEyeBall]

So, if my script downloads an updated version of itself(from somewhere on the internet), and updates itself, Could anything go wrong during the process(like corrupted data)?

And if so, how to fix it?

Edited November 4, 2013 by DatMCEyeBall

[guinness]

Well this simply runs a batch file that waits for the process to close and then performs a file move by moving the new executable to the old filename. Simple. So if you can think of something that can go wrong during this process then it will.