Add AD computer description to script/GUI

[water]

@error = 1 means: OU does not exist.

Do you specify the OU as FQDN like "OU=sampleou,OU=sampleparent,DC=sampledomain1,DC=sampledomain2"

Edited February 1, 2012 by water

[jazzyjeff]

Water,

Thanks for your patience on this. I am now back in the office and I am testing this out. I'll just continue to use this thread as we seem to have the same issue if that's ok.

I ran the script you compiled and I get this error:

_AD_Open: @error: -2147352567 @extended: 0

[water]

That's fine for me.

I will test and answer tomorrow as soon as I'm in my office again.

But I have to admit that this problem becomes more and more mysterious.

[mik3]

Water I select the OU with the tool you previously created, then I copy and paste it.

[water]

@jazzyjeff

There seems to be a problem with connecting to the AD.

Could you please run this code?

#include <ad.au3>
$iAD_Debug = 2
Global $AdminUserName = ""     ; Username with permissions to create computer accounts and set permisisons on the computer account in AD
Global $AdminUserPassword = ""   ; Password
Global $DomainName = ""        ; Optional: Domain name e.g. DC=microsoft,DC=com
Global $DomainController = ""    ; Optional: Name of Domain Controller e.g.DC-Server1.microsoft.com
Global $ConfigurationContext = ""   ; Optional: Configuration naming context e.g. CN=Configuration,DC=microsoft,DC=com
Global $OU = ""              ; Organizational unit to create the computer account in e.g. OU=Computer_Accounts,DC=microsoft,DC=com
Global $ComputerName = ""         ; Name of the computer account to create. SamAccountName without trailing "$" e.g. C0001
Global $Usergroup = ""         ; Name of the user account or group to join the physical computer to the domain
_AD_Open($AdminUserName, $AdminUserPassword, $DomainName, $DomainController, $ConfigurationContext)
If @error Then Exit MsgBox(16, "ADAT", "_AD_Open: @error: " & @error & ", @extended: " & @extended)
_AD_CreateComputer($OU, $ComputerName, $Usergroup)
If @error Then Exit MsgBox(16, "ADAT", "_AD_CreateComputer: @error: " & @error & ", @extended: " & @extended)
MsgBox(64, "ADAT", "Computer successfully created!")
_AD_Close()

[water]

@mik3

Could you please post the complete script you run including all parameters you've set? Please replace confidential infomation with xxx but leave the structure untouched e.g. "OU=computers,DC=microsoft,DC=com" can become "OU=computers,DC=xxxx,DC=com"

Or you can send me the code using the forums private mail feature.

[jazzyjeff]

The debug code gave me the following error:

[water]

@jazzyjeff,

the message is self-explanatory. Creating the computer account was succesful during one of the last test I assume.

[jazzyjeff]

Ah man! I hate it when i do this...

It's working now. I swear I tried all this stuff (except for downgrading the AutoIT).

Thanks for all your help as always.

Jeff

[water]

I'm glad the problem could be solved. 'Cause I was running out of ideas

[jazzyjeff]

Hey Water,

Well it was/is working again on XP, but Windows 7 still isn't working. The script will create the computer account in the AD domain, but the PC won't join to the domain, it just stays in a workgroup.

I have ran this as the local administrator "running as admin" and it still doesn't work. I guess I have given up on that part for my script.

I found this on the microsoft site that works for me.

Func _JoinDomain()
Const $JOIN_DOMAIN = 1
Const $ACCT_CREATE = 2
Const $ACCT_DELETE = 4
Const $WIN9X_UPGRADE = 16
Const $DOMAIN_JOIN_IF_JOINED = 32
Const $JOIN_UNSECURE = 64
Const $MACHINE_PASSWORD_PASSED = 128
Const $DEFERRED_SPN_SET = 256
Const $INSTALL_INVOCATION = 262144
Const $OU = "OU=" & $selSchool1 & ",OU=PC,OU=Workstations,DC=domain,DC=net"
$strDomain = "domain"
$strPassword = "password"
$strUser = "username"
$strComputer = @ComputerName
$objComputer = ObjGet("winmgmts:{impersonationLevel=Impersonate}!" & _
   $strComputer & "rootcimv2:Win32_ComputerSystem.Name='" _
    & $strComputer & "'")
$ReturnValue = $objComputer.JoinDomainOrWorkGroup($strDomain, _
   $strPassword, _
   $strDomain & "" & $strUser, _
   $OU, _
   $JOIN_DOMAIN + $ACCT_CREATE)
EndFunc   ;==>_JoinDomain

I appreciate your help with this. Just wanted to give you an fyi. I'm sure it's my script, but I just can't figure it out, but this wmi works.

Thanks for all your help.

Edited February 3, 2012 by jazzyjeff

[water]

I really don't understand why my script doesn't work because it does the same as the script you posted.

I searched the forum but could'nt find a problem with joining the domain and Windows 7.

But as you've solved your problem I think we can close this issue.

[mik3]

@Water,

It was an error on my part. The test script created the computer account. I got a popup that said "Computer successfully created!"

[mik3]

Do I need to change anything on the original script?

[water]

By "original script" you refer to the code I posted in #11?

[mik3]

Just the latest complete script.

[water]

I added the latest code of ADAT to post

[mik3]

Still getting error creating computer. I do not know what is wrong. The same test script, where you asked to add all my info, worked. Now using the stuff from post 11 does not.

http://static.inky.ws/image/1255/image.jpg

[water]

I will add some debugging code so we can see where the problem is ...

Stay tuned.

[water]

Here you find a version of the code with some MsgBox inserted to make sure we get the correct data and use the correct functions.

Can you run the script with the exact same data as you have used with the short test script I provided?

Can you then post the screenshots you get (make sure to gray out the sensitive data like password, domain name etc.)?

Edit:

Code removed - can now be found in the example thread for this UDF.

Edited April 15, 2012 by water