Dalex Posted October 15, 2011 Posted October 15, 2011 What am I doing wrong? I want this to write the current logged on user to the Computer description field. it works if I include a name inside the quotes but not it won't write the variable. I have included the message box just to show that it is the correct syntax to be written to console. #include <Process.au3> Dim $sComputerDesc = "net config server /srvcomment:" & @UserName MsgBox(0,"", $sComputerDesc) _RunDOS ( $sComputerDesc) [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
water Posted October 15, 2011 Posted October 15, 2011 (edited) Check the returncode and @error after _RunDOS. #include <Process.au3> Dim $sComputerDesc = "net config server /srvcomment:" & @UserName MsgBox(0,"", $sComputerDesc) $iReturnCode = _RunDOS ( $sComputerDesc) MsgBox(0, "After _RunDOS", "Returncode: " & $iReturnCode & ", @error: " & @error) What do you get? Edited October 15, 2011 by water My UDFs and Tutorials: Spoiler UDFs: Active Directory (NEW 2024-07-28 - Version 1.6.3.0) - Download - General Help & Support - Example Scripts - Wiki ExcelChart (2017-07-21 - Version 0.4.0.1) - Download - General Help & Support - Example Scripts OutlookEX (2021-11-16 - Version 1.7.0.0) - Download - General Help & Support - Example Scripts - Wiki OutlookEX_GUI (2021-04-13 - Version 1.4.0.0) - Download Outlook Tools (2019-07-22 - Version 0.6.0.0) - Download - General Help & Support - Wiki PowerPoint (2021-08-31 - Version 1.5.0.0) - Download - General Help & Support - Example Scripts - Wiki Task Scheduler (2022-07-28 - Version 1.6.0.1) - Download - General Help & Support - Wiki Standard UDFs: Excel - Example Scripts - Wiki Word - Wiki Tutorials: ADO - Wiki WebDriver - Wiki
Dalex Posted October 15, 2011 Author Posted October 15, 2011 I get this: Returncode:1, @error:0 What does that mean? [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
BrewManNH Posted October 15, 2011 Posted October 15, 2011 Have you tried it using just the Run command? If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator
Dalex Posted October 15, 2011 Author Posted October 15, 2011 Not sure what you mean? like this? Dim $sComputerDesc = "net config server /srvcomment:" & @UserName MsgBox(0,"", $sComputerDesc) $iReturnCode = Run( $sComputerDesc) MsgBox(0, "After _RunDOS", "Returncode: " & $iReturnCode & ", @error: " & @error) [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
BrewManNH Posted October 15, 2011 Posted October 15, 2011 Yes, run it without calling @Comspec first. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator
Dalex Posted October 15, 2011 Author Posted October 15, 2011 Thanks, I will try it when I get back home. [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
Dalex Posted October 16, 2011 Author Posted October 16, 2011 (edited) If this is what you mean, I don't understand how that could work. Run ("net config server /srvcomment:" & @UserName) This doesn't work either. _RunDOS ( "net config server /srvcomment:" & @UserName) Edited October 16, 2011 by Dalex [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
Dalex Posted October 16, 2011 Author Posted October 16, 2011 (edited) ok, I figured it out......You knew the answer the whole time didn't you? The command requires the desired value to be enclosed in quotes. I just had to double quote around the macro like this: #include <Process.au3> Dim $sComputerDesc = "net config server /srvcomment:" & '"'& @UserName & '"' _RunDOS($sComputerDesc) Hey Brewman, RDWHAHB, bet you know what that means too huh? Edited October 16, 2011 by Dalex [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
BrewManNH Posted October 16, 2011 Posted October 16, 2011 I didn't realize that it would need the quotes around the user name, because they don't usually have spaces in them. Unless the command for the comment needs the quotes, I would never have guessed it. p.s.: I'd have a homebrew, if the wife would let me make it If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator
Dalex Posted October 16, 2011 Author Posted October 16, 2011 Oh man I hate to hear that. If I could I would send you a couple. Where are you New Hampshire ? Thanks for the help, I have found that some times it takes someone on the outside looking in to help me break out of the box that is my simple mind. [size="2"][u]Beer is living proof that God loves us and wants us to be happy.-- Ben Franklin[/u][/size]
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now