My script only works sometimes on different computers

[wazer]

Hey guys i have used kodo's tool to make an simple gui and put some files into the root where i got my autoit exe files. The purpose is to have all the files in one program and launch them via that program..

I have made this for my world of tanks clan, now 2 people out of 7 is reporting that they cannot start some of the programs sometime, it simply does nothing. I then tought it was because of the program exiting to quick before it started the program so i added delay to 2000, but still no luck. They all had problem's with teamspeak 3 as shared app and some different apps.

Heres my code. Any help would be nice .

expandcollapse popup

#RequireAdmin
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Icon=E:\Programmer\BatchIconExtractor\icons\wucltux.dll_I003d_0409.ico
#AutoIt3Wrapper_Compression=4
#AutoIt3Wrapper_UseX64=n
#AutoIt3Wrapper_Res_Language=1030
#AutoIt3Wrapper_Add_Constants=n
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#Region ### START Koda GUI section ### Form=C:\Users\Administrator\Desktop\Form1.kxf

Opt("TrayIconHide", 1)
$Form1 = GUICreate("Voice Mix", 220, 307, 722, 298)
$MenuItem1 = GUICtrlCreateMenu("&File")
$MenuItem2 = GUICtrlCreateMenu("Drivers / Tools", $MenuItem1)
$MenuItem4 = GUICtrlCreateMenuItem("ATI / AMD", $MenuItem2)
$MenuItem5 = GUICtrlCreateMenuItem("nVidia", $MenuItem2)
$MenuItem6 = GUICtrlCreateMenuItem("Windows DirectX", $MenuItem2)
$MenuItem7 = GUICtrlCreateMenuItem("PingFix", $MenuItem2)
$MenuItem3 = GUICtrlCreateMenu("RFTN", $MenuItem1)
$MenuItem8 = GUICtrlCreateMenuItem("RFTN vWar", $MenuItem3)
$MenuItem9 = GUICtrlCreateMenuItem("RFTN Forum", $MenuItem3)
$MenuItem10 = GUICtrlCreateMenuItem("WoT Forum", $MenuItem3)
$TeamSpeak3 = GUICtrlCreateButton("TeamSpeak 3", 0, 0, 219, 41)
$Ventrilo3 = GUICtrlCreateButton("Ventrilo 3", 0, 40, 219, 41)
$Mumble = GUICtrlCreateButton("Mumble", 0, 80, 219, 41)
$Skype = GUICtrlCreateButton("Skype", 0, 120, 219, 41)
$GoogleTalk = GUICtrlCreateButton("Google Talk", 0, 160, 219, 41)
$Input1 = GUICtrlCreateInput("    TeamSpeak IP: 212.10.30.247", 24, 256, 177, 21)
$RFTN_EDITION = GUICtrlCreateGroup("RFTN EDITION", 16, 208, 185, 33)
GUICtrlCreateGroup("", -99, -99, 1, 1)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###




While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
            Case $TeamSpeak3
                teamspeak3()
            Case $Ventrilo3
                ventrilo3()
            Case $Mumble
                mumble()
            Case $Skype
                skype()
            Case $GoogleTalk
                googletalk()
            Case $MenuItem4
                __ATI()
            Case $MenuItem5
                __nVidia()
            Case $MenuItem6
                __directx()
            Case $MenuItem7
                __pingfix()
            Case $MenuItem8
                __vwar()
            Case $MenuItem9
                __forum()
            Case $MenuItem10
                __wotforum()
        Case $Form1
    EndSwitch
WEnd


;TOP MENU
;FIle
Func __ATI()
    ShellExecute("http://support.amd.com/us/Pages/AMDSupportHub.aspx")
EndFunc

Func __nVidia()
    ShellExecute("http://www.nvidia.co.uk/Download/index.aspx?lang=en-uk")
EndFunc

Func __directx()
    ShellExecute("http://www.microsoft.com/download/en/details.aspx?id=35")
EndFunc

Func __pingfix()
    ShellExecute("http://clan-dreamcast.com/wzr/PingFix.exe")
EndFunc

;TOPMENU
;RFTN
Func __forum()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=70")
EndFunc

Func __wotforum()
    ShellExecute("http://forum.worldoftanks.com/")
EndFunc


Func __vwar()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=58")
EndFunc


;BUTTONS LAUNCHERS
Func teamspeak3()
        Run("TeamSpeak\3\ts3client_win32.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func ventrilo3()
        Run("Ventrilo\3\Ventrilo.exe", "",@SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func mumble()
        Run("Mumble\mumble.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func skype()
        Run("SkypePortable\SkypePortable.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func googletalk()
        Run("GoogleTalk\PortableGoogleTalk.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

[water]

You really need to do some error checking in your script!

Just do Shellexecute and hope that everything works fine isn't enough.

Edited July 23, 2011 by water

[Kenna]

Hey guys i have used kodo's tool to make an simple gui and put some files into the root where i got my autoit exe files. The purpose is to have all the files in one program and launch them via that program..

I have made this for my world of tanks clan, now 2 people out of 7 is reporting that they cannot start some of the programs sometime, it simply does nothing. I then tought it was because of the program exiting to quick before it started the program so i added delay to 2000, but still no luck. They all had problem's with teamspeak 3 as shared app and some different apps.

Heres my code. Any help would be nice .

expandcollapse popup

#RequireAdmin
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Icon=E:\Programmer\BatchIconExtractor\icons\wucltux.dll_I003d_0409.ico
#AutoIt3Wrapper_Compression=4
#AutoIt3Wrapper_UseX64=n
#AutoIt3Wrapper_Res_Language=1030
#AutoIt3Wrapper_Add_Constants=n
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
#Region ### START Koda GUI section ### Form=C:\Users\Administrator\Desktop\Form1.kxf

Opt("TrayIconHide", 1)
$Form1 = GUICreate("Voice Mix", 220, 307, 722, 298)
$MenuItem1 = GUICtrlCreateMenu("&File")
$MenuItem2 = GUICtrlCreateMenu("Drivers / Tools", $MenuItem1)
$MenuItem4 = GUICtrlCreateMenuItem("ATI / AMD", $MenuItem2)
$MenuItem5 = GUICtrlCreateMenuItem("nVidia", $MenuItem2)
$MenuItem6 = GUICtrlCreateMenuItem("Windows DirectX", $MenuItem2)
$MenuItem7 = GUICtrlCreateMenuItem("PingFix", $MenuItem2)
$MenuItem3 = GUICtrlCreateMenu("RFTN", $MenuItem1)
$MenuItem8 = GUICtrlCreateMenuItem("RFTN vWar", $MenuItem3)
$MenuItem9 = GUICtrlCreateMenuItem("RFTN Forum", $MenuItem3)
$MenuItem10 = GUICtrlCreateMenuItem("WoT Forum", $MenuItem3)
$TeamSpeak3 = GUICtrlCreateButton("TeamSpeak 3", 0, 0, 219, 41)
$Ventrilo3 = GUICtrlCreateButton("Ventrilo 3", 0, 40, 219, 41)
$Mumble = GUICtrlCreateButton("Mumble", 0, 80, 219, 41)
$Skype = GUICtrlCreateButton("Skype", 0, 120, 219, 41)
$GoogleTalk = GUICtrlCreateButton("Google Talk", 0, 160, 219, 41)
$Input1 = GUICtrlCreateInput("    TeamSpeak IP: 212.10.30.247", 24, 256, 177, 21)
$RFTN_EDITION = GUICtrlCreateGroup("RFTN EDITION", 16, 208, 185, 33)
GUICtrlCreateGroup("", -99, -99, 1, 1)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###




While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
            Case $TeamSpeak3
                teamspeak3()
            Case $Ventrilo3
                ventrilo3()
            Case $Mumble
                mumble()
            Case $Skype
                skype()
            Case $GoogleTalk
                googletalk()
            Case $MenuItem4
                __ATI()
            Case $MenuItem5
                __nVidia()
            Case $MenuItem6
                __directx()
            Case $MenuItem7
                __pingfix()
            Case $MenuItem8
                __vwar()
            Case $MenuItem9
                __forum()
            Case $MenuItem10
                __wotforum()
        Case $Form1
    EndSwitch
WEnd


;TOP MENU
;FIle
Func __ATI()
    ShellExecute("http://support.amd.com/us/Pages/AMDSupportHub.aspx")
EndFunc

Func __nVidia()
    ShellExecute("http://www.nvidia.co.uk/Download/index.aspx?lang=en-uk")
EndFunc

Func __directx()
    ShellExecute("http://www.microsoft.com/download/en/details.aspx?id=35")
EndFunc

Func __pingfix()
    ShellExecute("http://clan-dreamcast.com/wzr/PingFix.exe")
EndFunc

;TOPMENU
;RFTN
Func __forum()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=70")
EndFunc

Func __wotforum()
    ShellExecute("http://forum.worldoftanks.com/")
EndFunc


Func __vwar()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=58")
EndFunc


;BUTTONS LAUNCHERS
Func teamspeak3()
        Run("TeamSpeak\3\ts3client_win32.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func ventrilo3()
        Run("Ventrilo\3\Ventrilo.exe", "",@SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func mumble()
        Run("Mumble\mumble.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func skype()
        Run("SkypePortable\SkypePortable.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

Func googletalk()
        Run("GoogleTalk\PortableGoogleTalk.exe", "", @SW_SHOWDEFAULT)
        sleep(2000)
        exit
EndFunc

You'll need to know what operating system they're on.

This may or may not help, try the #requireadmin attribute.

Good luck.

Edit: Breezed through it to quick, didn't see the requireadmin.

Still need which OSes though.

Edited July 23, 2011 by Kenna

[wazer]

You really need to do some error checking in your script!

Just do Shellexecute and hope that everything works fine isn't enough.

Thanks for the quick reply!.

What do you mean?. shellexecute works brilliant on all systems, nobody has reported any failures. What i learned is that shellexecute finds the default web browser and open the links i assigned to them. Thats it theres no problem in this.

You'll need to know what operating system they're on.

This may or may not help, try the #requireadmin attribute.

Good luck.

Edit: Breezed through it to quick, didn't see the requireadmin.

Still need which OSes though.

Hello thanks for the quick reply, they are all running windows7 64bit. Tho those 2 guys that are having problems is windows 7 home premium.

I dont compile in x64 only x86

If you guys are interrested into trying it with all the programs, you can download it here.

www.clan-dreamcast.com/wzr/VoiceMix.exe

i changed some of the code including #requireadmin to the top, tho im not sure if all the programs will be running as administrator? or those #requireadmin only assign to the script it self?, and if it does, is there a way to assign administrator launch to them all..

This i have tryed so far, and no luck.

Change from this

BUTTONS LAUNCHERS
Func teamspeak3()
    Run("TeamSpeak\3\ts3client_win32.exe", "", @SW_SHOWDEFAULT)
    exit
EndFunc

Func ventrilo3()
    Run("Ventrilo\3\Ventrilo.exe", "",@SW_SHOWDEFAULT)
    exit
EndFunc

Func mumble()
    Run("Mumble\mumble.exe", "", @SW_SHOWDEFAULT)
    exit
EndFunc

Func skype()
    Run("SkypePortable\SkypePortable.exe", "", @SW_SHOWDEFAULT)
    exit
EndFunc

Func googletalk()
        Run("GoogleTalk\PortableGoogleTalk.exe", "", @SW_SHOWDEFAULT)
        exit
EndFunc

To this

;BUTTONS LAUNCHERS
Func teamspeak3()
    Run(@ScriptDir & "\teamSpeak\3\ts3client_win32.exe", "", @SW_SHOWDEFAULT)

EndFunc

Func ventrilo3()
    Run(@ScriptDir & "\ventrilo\3\Ventrilo.exe", "",@SW_SHOWDEFAULT)

EndFunc

Func mumble()
    Run(@ScriptDir & "\mumble\mumble.exe", "", @SW_SHOWDEFAULT)

EndFunc

Func skype()
    Run(@ScriptDir & "\skype\SkypePortable.exe", "", @SW_SHOWDEFAULT)

EndFunc

Func googletalk()
        Run(@ScriptDir & "\googletalk\PortableGoogleTalk.exe", "", @SW_SHOWDEFAULT)

EndFunc

Edited July 23, 2011 by wazer

[water]

What do you mean?. shellexecute works brilliant on all systems, nobody has reported any failures. What i learned is that shellexecute finds the default web browser and open the links i assigned to them. Thats it theres no problem in this.

I don't mean shellexecute itself but the program you start with shellexecute.

Let's say you try to run program xy.exe but this program is not available at the host. As you dont' do any checks you can't tell if the program ran successfully or not.

Everywhere in your script where you use Shellexecute to open a web page I would use function _IECreate. You check the returncode and see if the function was successful.

Replace "Run(...)" with $iResult = Run(...)" so you can check the result. If $iResult = 0 then there was an error (program could not be found or whatever). How to check if the program ran successfully depends on the program.

[wazer]

I don't mean shellexecute itself but the program you start with shellexecute.

Let's say you try to run program xy.exe but this program is not available at the host. As you dont' do any checks you can't tell if the program ran successfully or not.

Everywhere in your script where you use Shellexecute to open a web page I would use function _IECreate. You check the returncode and see if the function was successful.

Replace "Run(...)" with $iResult = Run(...)" so you can check the result. If $iResult = 0 then there was an error (program could not be found or whatever). How to check if the program ran successfully depends on the program.

I used _IECreate at the beginning, but people reported that they did not use IE, and they did not have saved logins/passwords with ie, instead they were using either firefox or chrome, so i found that solution, and infact it works really well . And now it just opens the default assigned browser to each system they are running.

But anyways, i think i found the solution "perhaps" for some programs not starting at all.

How can i make sure that the external programs is running by administrator rights in windows 7 without you have to type their computername and password?.

I understand that #Requireadmin is only for the script it self and was made for windows vista, so actually that options is really pointless?, because my program dont really need any admin rights only the externals, mine does only open external programs and open a few websites with the default selected web browser.

Edited July 23, 2011 by wazer

[wazer]

bump

[water]

Please wait at least 24 hours before bumping a thread.

[wazer]

Please wait at least 24 hours before bumping a thread.

Hey what about helping me instead of making summary of my rights

[wazer]

Here we go the laste code i did.

expandcollapse popup

#RequireAdmin
#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Icon=E:\Programmer\BatchIconExtractor\icons\wucltux.dll_I003d_0409.ico
#AutoIt3Wrapper_Compression=4
#AutoIt3Wrapper_UseX64=n
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****


#include <ButtonConstants.au3>
#include <EditConstants.au3>
#include <GUIConstantsEx.au3>
#include <WindowsConstants.au3>
Opt("TrayIconHide", 1)


 If IsAdmin() = 0 Then
     MsgBox(0, "Local Admin Rights not detected", "Local Admin rights are required for this to run with external programs" & @CRLF    _
     & "Please login with Admin rights, you can continue but i wont promise it will run as intended")
 EndIf





$Form1 = GUICreate("VoiceMix", 220, 307, 722, 298)
$MenuItem1 = GUICtrlCreateMenu("&File")
$MenuItem2 = GUICtrlCreateMenu("Drivers / Tools", $MenuItem1)
$MenuItem4 = GUICtrlCreateMenuItem("ATI / AMD", $MenuItem2)
$MenuItem5 = GUICtrlCreateMenuItem("nVidia", $MenuItem2)
$MenuItem6 = GUICtrlCreateMenuItem("Windows DirectX", $MenuItem2)
$MenuItem7 = GUICtrlCreateMenuItem("PingFix", $MenuItem2)
$MenuItem3 = GUICtrlCreateMenu("RFTN", $MenuItem1)
$MenuItem8 = GUICtrlCreateMenuItem("RFTN vWar", $MenuItem3)
$MenuItem9 = GUICtrlCreateMenuItem("RFTN Forum", $MenuItem3)
$MenuItem10 = GUICtrlCreateMenuItem("WoT Forum", $MenuItem3)
$teamSpeak3 = GUICtrlCreateButton("TeamSpeak 3", 0, 0, 219, 41)
$ventrilo3 = GUICtrlCreateButton("Ventrilo 3", 0, 40, 219, 41)
$mumble = GUICtrlCreateButton("Mumble", 0, 80, 219, 41)
$skype = GUICtrlCreateButton("Skype", 0, 120, 219, 41)
$googletalk = GUICtrlCreateButton("Google Talk", 0, 160, 219, 41)
$Input1 = GUICtrlCreateInput("    TeamSpeak IP: 212.10.30.247", 24, 256, 177, 21)
$rftn = GUICtrlCreateGroup("RFTN EDITION", 16, 208, 185, 33)
GUICtrlCreateGroup("", -99, -99, 1, 1)
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###




While 1
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            Exit
            Case $teamSpeak3
                teamspeak3()
            Case $ventrilo3
                ventrilo3()
            Case $mumble
                mumble()
            Case $skype
                skype()
            Case $googletalk
                googletalk()
            Case $MenuItem4
                __ati()
            Case $MenuItem5
                __nvidia()
            Case $MenuItem6
                __directx()
            Case $MenuItem7
                __pingfix()
            Case $MenuItem8
                __vwar()
            Case $MenuItem9
                __forum()
            Case $MenuItem10
                __wotforum()
            Case $rftn
                __rftn()
        Case $Form1
    EndSwitch
WEnd


;TOP MENU
;FIle
Func __ati()
    ShellExecute("http://support.amd.com/us/Pages/AMDSupportHub.aspx")
EndFunc

Func __nvidia()
    ShellExecute("http://www.nvidia.co.uk/Download/index.aspx?lang=en-uk")
EndFunc

Func __directx()
    ShellExecute("http://www.microsoft.com/download/en/details.aspx?id=35")
EndFunc

Func __pingfix()
    ShellExecute("http://clan-dreamcast.com/wzr/PingFix.exe")
EndFunc

;TOPMENU
;RFTN
Func __forum()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=70")
EndFunc

Func __wotforum()
    ShellExecute("http://forum.worldoftanks.com/")
EndFunc

Func __vwar()
    ShellExecute("http://rftn.eu/index.php?option=com_wrapper&view=wrapper&Itemid=58")
EndFunc

Func __rftn()
    ShellExecute("http://rftn.eu/")
EndFunc



;BUTTONS LAUNCHERS
Func teamspeak3()
    Run(@ScriptDir & "\teamSpeak\3\ts3client_win32.exe", "", @SW_SHOWDEFAULT)
        sleep(500)
     exit
EndFunc

Func ventrilo3()
    Run(@ScriptDir & "\ventrilo\3\Ventrilo.exe", "",@SW_SHOWDEFAULT)
    sleep(500)
     exit
EndFunc

Func mumble()
    Run(@ScriptDir & "\mumble\mumble.exe", "", @SW_SHOWDEFAULT)
        sleep(500)
     exit
EndFunc

Func skype()
    Run(@ScriptDir & "\skype\SkypePortable.exe", "", @SW_SHOWDEFAULT)
        sleep(500)
     exit
EndFunc

Func googletalk()
        Run(@ScriptDir & "\googletalk\PortableGoogleTalk.exe", "", @SW_SHOWDEFAULT)
        sleep(500)
     exit
EndFunc

[Newbercase]

I downloaded and tested your code on XP SP-3 and it works! Not sure what would be causing the problem with Windows 7

As Water has pointed out that you may need to find out what is causing the error and blocking the script from running on Win7

[wazer]

Yeah i found the error, but i dont know how to do it corretly. Please any help would be nice

If uac is default as in this picture on computers running this script, then teamspeak 3 wont start neither will mumble in windows 7.

Tho if i disable UAC, and reboots the pc then it works. So i need to figure out another way to start those programs with a script that runs them as administrator.

[Zedna]

Hey guys i have used kodo's tool to make an simple gui and put some files into the root where i got my autoit exe files. The purpose is to have all the files in one program and launch them via that program..

Look at FileInstall() and my Resources UDF.

[wazer]

Look at FileInstall() and my Resources UDF.

I have no idea how to implent your script into it

[Zedna]

I have no idea how to implent your script into it

If Resources UDF is complicated for you then use simpler FileInstall(), details and examples are in Autoit's helpfile.