Winclose (or WinKill) not working

[DenDuze]

Hello,

I'm a new user of AutoIt and I have the following problem:

- have a au3-script that does some processing (getting some values and check a few items

- when everything is OK I call a function (that exist in a included au3-script)

- that function creates a GUI, that GUI works with then 'Opt("GUIOnEventMode", 1)'

- In that included-file there are only functions that process the user-events

- Now is my problem that when they click OK (or they close the GUI) I want to return processing my original script (all the lines after the GUI-create) so I want to close this GUI window but I'm probably doing something wrong.

Simplified I have the following

Master Script:

#include <file2.au3>

<multiple checks>

if <all checks are ok> then func-CreateWindow()

msgbox(......)

file2.au3

Opt("MustDeclareVars", 1)

func func-CreateWindow()

....

$Screen = GUICreate("Generate", 400, 150)

GUISetOnEvent($GUI_EVENT_CLOSE, "Func-CloseThisWindow")

EnvSet("BSCREEN",$Screen)

...

while 1

Sleep(1000) ; Idle

WEnd

EndFunc

func func-CloseThisWindow()

local $Screen

$screen = EnvGet("BSCREEN")

winclose($Screen)

EndFunc

Now when I click the window-close button the GUI-screen stays vissible and I don't get the MsgBox that is coded just after the func-CreateWindow (in my masterscript)

I've tried multiple variations to do this but always the same result.

The only thing that works is to use a Exit-statement but then my main program also stops and that's not the wanted behaviour

What I'm I doing wrong?

Note: I will change the whole setup (first create my window - then I will do my tests and if something is not Ok I will stop the program (with exit because that works ok). But I still like to know what's my problem with my first method.

Thanks

Didier

[Melba23]

DenDuze,

Welcome to the AutoIt forum.

A novel way of coding, if I may say so.

Your problem arises because you have no way of escaping from the While...WEnd loop in file2.au3. In keeping with the coding style you are using, I would suggest something along these lines (look for the <<<<<<<<<<<<<<<<<<<< lines:

Func CreateWindow()

    $Screen = GUICreate("Generate", 400, 150)
    EnvSet("BSCREEN",$Screen)
    EnvSet("GUIEXIT", 0) ; Create an envvar to keep us in the loop <<<<<<<<<<<<<<<<<<<<
    GUISetOnEvent($GUI_EVENT_CLOSE, "CloseThisWindow")
    GUISetState()

    While EnvGet("GUIEXIT") = 0 ; Check the envvar <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
        Sleep(1000) ; Idle
    WEnd

EndFunc   ;==>CreateWindow

Func CloseThisWindow()

    $Screen = EnvGet("BSCREEN")
    GUIDelete($Screen) ; Better to use this as you created it <<<<<<<<<<<<<<<<<<<<<<<<<
    EnvSet("GUIEXIT", 1) ; Set the envvar to exit the loop <<<<<<<<<<<<<<<<<<<<<<<<<<<<


EndFunc   ;==>CloseThisWindow

I get back to the calling script with no problems now.

Note that the function names you were using are invalid - from the Help file:

"Function names must start with either a letter or an underscore, and the remainder of the name can contain any combination of letters and numbers and underscores"

M23

P.S. When you post code please use Code tags. Put [autoit ] before and [/autoit ] after your posted code (but omit the trailing space - it is only there so the tags display here). Or press the blue button just under the BOLD toolbar button.

[DenDuze]

@Melba23: thanks for your answer

Whats so novel on this code?

For the function-names:

In our company we have some naming-conventions and I'm only applying these rules also in this script (so it is the same as all out other coding)

I will keep in mind the info about the autoit-tags

Regards

[Melba23]

DenDuze,

I used the word "novel" because I would have expected the code you have put into an #include file to be a simple function within the main script. There is nothing wrong with doing it your way - it is just that I have not seen it before.

Why do you do it this way? Is it to reduce the size of the main script when editing?

M23

[GEOSoft]

You would really love the way Project Express is written then. It would drive you over the edge I'm afraid.

[Melba23]

George,

I think I am already over it - or at least it feels like that sometimes!

M23

[GEOSoft]

I think I am already over it

M23

I concur

[hg2051]

At least when wanting to kill Ecel 2007, "WinKill" works only if followed by "ProcessClose"