Making first tab show in GUI

[pl123]

I borrowed the following script to add to my GUI from this link,

So I changed it around a bit, and added into the GUI.

However, whenever I run it, it gives the me error

'Next' statement with no matching 'For' statement

However, there is a For statement before the Next statement...

What's wrong? Thanks! Also, I've marked the errors in the code.

expandcollapse popup

Func _HighestRes ()
    Local $tDEVMODE = DllStructCreate ('byte[32];dword[10];byte[32];dword[6]')
    Local $pDEVMODE = DllStructGetPtr ($tDEVMODE)
    Local $i = 0, $Ret
    $Res = ""

    ; popluate resources into buffer
    While 1
        $Ret = DllCall('user32.dll', 'int', 'EnumDisplaySettings', 'ptr', 0, 'dword', $i, 'ptr', $pDEVMODE)
        If (@error) Or ($Ret[0] = 0) Then
            ExitLoop
        EndIf
        $HighWidth = DllStructGetData ($tDEVMODE, 4, 2)
        $HHeight = DllStructGetData ($tDEVMODE, 4, 3)
        $Bits = DllStructGetData ($tDEVMODE, 4, 1)
        $Res = $Res & $HighWidth & "," & $HighHeight & "," & $Bits & ":"
        $i += 1
    WEnd

    $arrRes = StringSplit($Res, ":") ; Split string using : as delimiter

    $ColorDepth = 0
    For $i = 1 To 5000
        $tmp1 = StringSplit($arrRes[$i], ",")
        If @error Then
            ExitLoop
        If UBound($tmp1) = 4 Then ; check if array has 4 elements (640, 480, 8, null), if so, obtain the highest color depth from the array
            If Number($tmp1[3]) > $ColorDepth Then
                $ColorDepth = Number($tmp1[3])
            EndIf
        EndIf
    Next ; ERROR!

    $XResHigh = 0
    For $i = 1 To 5000
        $tmp1 = StringSplit($arrRes[$i], ",")
        If @error Then
            ExitLoop
        If UBound($tmp1) = 4 Then; check if array has 4 elements (640, 480, 8, null), if so, obtain the highest color depth from the array
            If Number($tmp1[1]) > $XResHigh Then
                $XResHigh = Number($tmp1[1])
            EndIf
        EndIf
    Next ; ERROR!

    $YResHigh = 0
    For $i = 1 To 5000
        $tmp1 = StringSplit($arrRes[$i], ",")
        If @error Then
            ExitLoop
        If UBound($tmp1) = 4 Then ; check if array has 4 elements (640, 480, 8, null), if so, obtain the highest color depth from the array
            If Number($tmp1[1]) = $XResHigh Then ; only query array objects that match the X resolution
                If Number($tmp1[2]) > $YResHigh Then
                    $YResHigh = Number($tmp1[2])
                EndIf
            EndIf
        EndIf
    Next ; ERROR!
EndFunc

I have several tabs in my GUI, and when I run it, the first tab doesn't show anything, until I click on another tab then click on that first tab. I tried using

While 1
    $GetMsg = GUIGetMsg (0)
    Switch $GetMsg
        Case $Tab[0]
            GUICtrlSetState ($CTRLID, $GUI_SHOW)
    EndSwitch
WEnd

but all that does is make it flash a lot. How do I fix that?

Thanks for your help! =)

Edited November 20, 2010 by pl123

[BrewManNH]

You have an error in your If...Endif command loop

Yours:

For $i = 1 To 5000
        $tmp1 = StringSplit($arrRes[$i], ",")
        If @error Then
            ExitLoop
        If UBound($tmp1) = 4 Then ; check if array has 4 elements (640, 480, 8, null), if so, obtain the highest color depth from the array
            If Number($tmp1[1]) = $XResHigh Then ; only query array objects that match the X resolution
                If Number($tmp1[2]) > $YResHigh Then
                    $YResHigh = Number($tmp1[2])
                EndIf
            EndIf
        EndIf
    Next ; ERROR!

What it should look like:

For $i = 1 To 5000
        $tmp1 = StringSplit($arrRes[$i], ",")
        If @error Then = ExitLoop ; <<<<<<<<<<<<<<<<<<<<<<< error was here
        If UBound($tmp1) = 4 Then ; check if array has 4 elements (640, 480, 8, null), if so, obtain the highest color depth from the array
            If Number($tmp1[1]) = $XResHigh Then ; only query array objects that match the X resolution
                If Number($tmp1[2]) > $YResHigh Then
                    $YResHigh = Number($tmp1[2])
                EndIf
            EndIf
        EndIf
    Next ; ERROR!

Another way, depending on what you're looking to do with them

If @error Then
    ExitLoop
Endif

[pl123]

Thanks for your reply, BrewManNH! I got it fixed. =) Now, can anyone help me with my second problem? Thanks!

Edited November 20, 2010 by pl123

[martin]

Thanks for your reply, BrewManNH! I got it fixed. =) Now, can anyone help me with my second problem? Thanks!

What is your second problem?

[pl123]

The second problem is in the first post, but my problem is making the first tab show when I run the GUI. When I use $GUI_SHOW, it the tab flash over and over really fast.

[martin]

The second problem is in the first post, but my problem is making the first tab show when I run the GUI. When I use $GUI_SHOW, it the tab flash over and over really fast.

I would need to see your code to see how you create the tab and to reproduce the problem, otherwise I can't know what's wrong.