Jump to content

MsgBox/MessageBox - Move and change button text


SmOke_N
 Share

Recommended Posts

What's not working?

I just tested this, found out that you're using the wrong flag for your msgbox. The flag #48 corresponds to $MB_ICONWARNING, when you use that by itself it tells AutoIt to create a msgbox with one button and the warning icon inside it. If you want both buttons to show up, you have to use one of the flags that has more than one button displayed. If you replace your _MsgBoxEx(48, with _MsgBoxEx(52, then it will show both buttons with the correct text on them.

BTW, if you only specify text for 2 buttons and use a 3 button message box flag, the first button's text won't change.

Edited by BrewManNH

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Link to comment
Share on other sites

Works fine for me, except that flag=48 only displays one button.

_MsgBoxEx(1+48, "Test", "Taste", -1, -1, "Pest", "Paste")
 

P.S.: Upsa, didn't saw the answer on page 2 of the thread :)...

Edited by KaFu
Link to comment
Share on other sites

  • 8 years later...

I found this wasn't working when trying to set a button text using Chinese characters while running Arabic Windows.  What I discovered after a lot of poking around was that the following change fixed the issue.

The original code inside _CBT_MsgBoxProc() function

If _WinAPI_GetDlgItem($h_msgbox, $iid) Then
                        DllCall("User32.dll", "int", "SetDlgItemText", "hwnd", $h_msgbox, _
                            "int", $iid, "str", $__aMsgBoxText[$iid])
                    EndIf

should be changed to

If _WinAPI_GetDlgItem($h_msgbox, $iid) Then
                        DllCall("User32.dll", "int", "SetDlgItemTextW", "hwnd", $h_msgbox, _
                            "int", $iid, "wstr", $__aMsgBoxText[$iid])
                    EndIf

This uses the Unicode version of the SetDlgItemText function, SetDlgItemTextW, and instead of passing a "str", it needs to pass a "wstr".

Link to comment
Share on other sites

  • 9 months later...

I know this is a very late arrival to the party but I found and fixed a bug in the MsgBoxUDF.au3 file that others might find helpful.

The bug only appears if you use the _MsgBoxEx function to set your position and button texts all in one command rather than using the  _MsgBox_SetWindowPos, _MsgBox_SetButtonText, _MsgBox series of function calls.

In the _MsgBoxEx function, it attempts to determine which flag (1 through 6) you are using with the msgbox to know how many buttons you have to work with. It does this with this snippet of code:

Local $i_button_flag = 0
For $iflag = 1 To 6
    If BitAND($i_flag, $iflag) = $iflag Then
        $i_button_flag = $iflag
        ExitLoop
    EndIf
Next

There's a logical flaw in this code snippet. As written, it tests the possible values in order of 1, 2, 3, 4, 5, 6 to see which is a bitwise match with the flag passed in. However, when starting with the lowest possible number, the first test is BitAND(flag, 1). In this case, if the flag is 1, 3, or 5, this test will return 1 since BitAND(1,1) = 1, BitAND(3,1) = 1, and BitAND(5,1) = 1.  In binary mode, it's BitAND(0001,0001) which returns 0001; BitAND(0011,0001) which returns 0001; and BitAND(0101,0001) which returns 0001. All of these return 1 since they all have the the right-most bit as 1.

So if the msgbox was supposed to be either $MB_OKCANCEL (1), $MB_YESNOCANCEL (3), or $MB_RETRYCANCEL (5), the code snippet is always going to think it was $MB_OKCANCEL. And as such, the button renaming doesn't work properly if $MB_YESNOCANCEL (with three buttons) was actually the intended flag.

The logic fix is simple. Test the possible flag values starting at the highest (6) and working back down to the lowest (1). Like this:

Local $i_button_flag = 0
For $iflag = 6 To 1 Step -1  ; <--- change this one line of code
    If BitAND($i_flag, $iflag) = $iflag Then
        $i_button_flag = $iflag
        ExitLoop
    EndIf
Next
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...