Active Directory UDF - Help & Support

[paullauze]

thanks for that bit of info, it was definately pointing in the right direction. i was able to paste a piece of sample code into an Excel macros and to my surprise - it worked for the most part. i have a few things to work out like i need to connect to z: intead of the local server but that has been a huge help.

maybe i can work that into the AD UDF

thanks

[water]

According to this article you should be able to read/write TS properties.

I think it should be possible using _AD_GetObjectAttribute and _AD_ModifyAttribute.

[jazzyjeff]

I have a script which I am trying to get the last logon of all machines in all OU's in my AD structure. The script terminates with an error on the 3rd OU. I am not sure why. Can you see any problems in this script? The first 2 OU's cycle through the machines fine.

Thanks.

#include <AD.au3>
_AD_Open()
Global $aOUs = _AD_GetAllOUs()
If Not FileExists ("C:\Temp") Then
DirCreate("C:\Temp")
EndIf
For $a = 1 To $aOUs[0][0]
$aObj = _AD_GetObjectsInOU($aOUs[$a][1],"(objectclass=computer)")
;MsgBox(0,"OU",$aObj[0] & @CR & $aOUs[$a][1])
For $b = 1 To $aObj[0]
  ;MsgBox(0,"Computer",$aObj[$b] & @CR & $aOUs[$a][1])
  $aProp = _AD_GetObjectProperties($aObj[$b],"lastLogon")
  MsgBox(0,"Date",$aObj[$b] & "=" & $aProp[1][1])
Next
Next
_AD_Close()

Error:

D:\Backup\AutoIT Script\Active Directory\AD Stale Computer Search.au3 (13) : ==> Subscript used with non-Array variable.:

For $b = 1 To $aObj[0]

For $b = 1 To $aObj^ ERROR

[BrewManNH]

What does _AD_GetObjectsInOU return if there's nothing in the OU?

[jazzyjeff]

Ah that is a good point. :-) Let me figure that out and I'll get back with my success or failure.

Thanks.

[water]

_AD_GetObjectsInOU returns "" if there is no data to return and sets @error. Try this:

#include <AD.au3>
_AD_Open()
Global $aOUs = _AD_GetAllOUs()
If Not FileExists("C:Temp") Then
    DirCreate("C:Temp")
EndIf
For $a = 1 To $aOUs[0][0]
    $aObj = _AD_GetObjectsInOU($aOUs[$a][1], "(objectclass=computer)")
    If @error = 0 Then
        For $b = 1 To $aObj[0]
            $aProp = _AD_GetObjectProperties($aObj[$b], "lastLogon")
            MsgBox(0, "Date", $aObj[$b] & "=" & $aProp[1][1])
        Next
    EndIf
Next
_AD_Close()

[jazzyjeff]

Thank you very much water. That worked great!

[jazzyjeff]

OK, I jumped the gun there. So that code worked up until it got to the 9th machine in the OU (there are 79), but for some receiving at that 9th machine I am receiving this error message.

D:BackupAutoIT ScriptActive DirectoryAD Stale Computer Search.au3 (19) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

ConsoleWrite($aObj[$b] & "=" & $aProp[1][1] & @CR)

ConsoleWrite($aObj[$b] & "=" & ^ ERROR

Why would it throw an error in the middle of loop?

[water]

How does the code you run now look like? There is no ConsoleWrite in the code you posted above.

[jazzyjeff]

Sorry I modified it a little, so I could see where it was breaking a little better.

#include <AD.au3>
_AD_Open()
Global $aOUs = _AD_GetAllOUs()
If Not FileExists ("C:\Temp") Then
DirCreate("C:\Temp")
EndIf
For $a = 1 To $aOUs[0][0]
;MsgBox(0,"",$aOUs[$a][1])
$aObj = _AD_GetObjectsInOU($aOUs[$a][1],"(objectclass=computer)")
;MsgBox(0,"OU",$aObj[0] & @CR & $aOUs[$a][1])
If @error = 0 Then
  ;MsgBox(0,"OU",$aObj[0] & @CR & $aOUs[$a][1])
  For $b = 1 To $aObj[0]
   ;MsgBox(0,"Computer",$aObj[$b] & @CR & $aOUs[$a][1])
   $aProp = _AD_GetObjectProperties($aObj[$b],"lastLogon")
   ConsoleWrite($aObj[$b] & "=" & $aProp[1][1] & @CR)
  Next
EndIf
Next
_AD_Close()

[water]

I'm sure _AD_GetObjectProperties returns an error. Insert

ConsoleWrite(@error & @CRLF)

after _AD_GetObjectProperties and you will see what goes wrong. In case of an error the function doesn't return an array but a string.

[jazzyjeff]

So this is the code I used.

#include <AD.au3>
_AD_Open()
Global $aOUs = _AD_GetAllOUs()
If Not FileExists ("C:Temp") Then
 DirCreate("C:Temp")
EndIf
For $a = 1 To $aOUs[0][0]
 ;MsgBox(0,"",$aOUs[$a][1])
 $aObj = _AD_GetObjectsInOU($aOUs[$a][1],"(objectclass=computer)")
 MsgBox(0,"OU",$aObj[0] & @CR & $aOUs[$a][1])
 If @error = 0 Then
  ;MsgBox(0,"OU",$aObj[0] & @CR & $aOUs[$a][1])
  For $b = 1 To $aObj[0]
   MsgBox(0,"Computer",$aObj[$b] & @CR & $aOUs[$a][1])
   $aProp = _AD_GetObjectProperties($aObj[$b],"lastLogon")
   ConsoleWrite(@error & @CRLF)
   ConsoleWrite($aObj[$b] & "=" & $aProp[1][1] & @CR)
  Next
 EndIf
Next
_AD_Close()

This is what I received back.

BACKUPSTORE$=2012/04/30 16:30:03

0

CAD-LICSRV1$=2012/05/12 01:33:28

0

D:BackupAutoIT ScriptActive DirectoryAD Stale Computer Search.au3 (20) : ==> Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

ConsoleWrite($aObj[$b] & "=" & $aProp[1][1] & @CR)

ConsoleWrite($aObj[$b] & "=" & ^ ERROR

I can't get anything from that. Do you see anything that could be causing an issue?

Thanks.

[water]

In the remarks section of the function you find: "No error is returned if there are properties in $sAD_Properties that are not available for the selected object".

So I would check for the returned data like this:

If IsArray($aProp) and $aProp[0][0] > 0 Then ConsoleWrite($aObj[$b] & "=" & $aProp[1][1] & @CR)

Edited May 16, 2012 by water

[jazzyjeff]

Water, thank you! That worked great.

[Syed23]

Hi Water!,

How are you? i m fine! now i currently working on a task which has to retrive the data from AD. Let me explain my input below.

When i execute the tool, it should collect all the country names. from my AD structure.

For example: in my AD i will be have hirarchies like, workstation->GD2000->(Europe,US,Asiapacific,etc.) under this regions i will having lot of country names. As a first step it should collect me the regions details.

After collecting that region details if i select any region it should explore all the country name which comes under that region.

Then the next step if i select any country name it should explore the city name. From that city name i should be able to select the machine models from the AD and it's name.

is that possible to do with our AD function? Please help me on this Water! i know this is a big task for me, but if you help i can complete it so easily!

[water]

HI Syed,

glad to hear you're fine. I'm doing well too.

What kind of objects do you use to create the hierarchy? OU's, CN's, groups ...?

[Syed23]

i always uses OU's

[water]

You then could give the example script a try.

[Syed23]

ok! Let me try that option and i'll get back to you on this....

[Syed23]

Hi Water,

That shows perfect. my quick question now i have been listed with all the OU site. and i have selected the OU. is there a way to find the user details based on the machine model?

For example, if i have HPXXXX model in one OU arround 30 users and HPYYYY model we have 300 users. is there a way to find the user list based on the model?