Detecting External Hard Drives

[abaddon7734]

I had problem differentiating drives of system and External drives as they're both of same type - "FIXED" when using DriveGetDrive and DriveGetType, so managed to make a small script to detect External ones.

Im a newb, so you may will find silly, unnecessary code which could have been done better with smart work instead of hard work, if you know what i mean

expandcollapse popup

#include <Array.au3>

Local $drivelist = DriveGetDrive("FIXED"), $addspace = 0, $getspace, $systemdrives, $externaldrives
;~ _ArrayDisplay($drivelist)
findexthdd()

Func findexthdd()
RunWait(@ComSpec & " /c " & 'wmic diskdrive get PNPDeviceID, size /format:csv | find /v "USBSTOR" > wmic.txt', @ScriptDir, @SW_HIDE)
$file = FileOpen("wmic.txt")
$readfile = FileRead($file)

$readfile = StringSplit($readfile, ",")
;~ _ArrayDisplay($readfile)
$last = $readfile[0]
$totalsize = $readfile[$last]
$totalsize = $totalsize / 1024 / 1024 / 1024 ;MB
Do
Local $c = 1
$totalsize = StringTrimRight($totalsize, $c)
$c = $c + 1
$return = StringInStr($totalsize, ".")
Until $return = 0
$return = 1

For $w = 1 To UBound($drivelist) - 1
$getspace = DriveSpaceTotal($drivelist[$w]) / 1024
Do
Local $z = 1
$getspace = StringTrimRight($getspace, $z)
$z = $z + 1
$return = StringInStr($getspace, ".")
Until $return = 0
$addspace += $getspace
If $addspace <= $totalsize Then ;463 vs 465
$systemdrives &= $drivelist[$w] & ","
Else
;~ MsgBox(0, "", $drivelist[$w] & " is the f****** external hard drive!")
$externaldrives &= $drivelist[$w] & ","
EndIf
Next

$systemdrives = StringTrimRight($systemdrives, 1)
$systemdrives = StringSplit($systemdrives, ",")
_ArrayDisplay($systemdrives, "SYSTEM DRIVES LIST")

$externaldrives = StringTrimRight($externaldrives, 1)
$externaldrives = StringSplit($externaldrives, ",")
_ArrayDisplay($externaldrives, "EXTERNAL DRIVES LIST")
EndFunc ;==>findexthdd

[wraithdu]

There's nothing wrong with your method at all. Some might say it's not foolproof because it relies on WMI being enabled on the target system (which is the default, but can be disabled).

I wrote a UDF for a different purpose some time ago, but it can gather the information you need, it even has an _IsUSBHDD test to do exactly what you want. Maybe you'll find it useful as well.

[wakillon]

Interesting !

Works well

I have tried to simplify you code a bit.

#include <Array.au3>

$aExternalDrives = _FindExtHdd()
_ArrayDisplay ( $aExternalDrives, "EXTERNAL DRIVES LIST" )

Func _FindExtHdd()
    Local $iPid, $sStdout, $iTotalSize, $sGetSpace, $addspace, $externaldrives
    $iPid = Run ( @ComSpec & ' /c wmic diskdrive get PNPDeviceID, size /format:csv | find /v "USBSTOR"', '', @SW_HIDE, 2 )
    While ProcessExists ( $iPid )
        $sStdout &= StdoutRead ( $iPid )
    Wend
    $sStdout = StringSplit($sStdout, ",")
    $iTotalSize = $sStdout[$sStdout[0]] / 1024 / 1024 / 1024 ; GB
    Do
        $iTotalSize = StringTrimRight($iTotalSize, 1 )
    Until Not StringInStr($iTotalSize, ".")
    Local $aDriveList = DriveGetDrive("FIXED")
    For $w = 1 To UBound($aDriveList) - 1
        $sGetSpace = DriveSpaceTotal($aDriveList[$w]) / 1024
        Do
            $sGetSpace = StringTrimRight($sGetSpace, 1 )
        Until Not StringInStr($sGetSpace, ".")
        $addspace += $sGetSpace
        If $addspace > $iTotalSize Then $externaldrives &= $aDriveList[$w] & ","
    Next
    $externaldrives = StringTrimRight($externaldrives, 1)
    If $externaldrives Then Return StringSplit($externaldrives, ",", 1)
EndFunc ;==>_FindExtHdd

[careca]

Hello abaddon7734,

why don't you make it wider, and have listed internal and external in one gui? ListView or something.

All i get when i run this, is a list of the drives i got, all represented as external.

Edited March 18, 2013 by careca

[AZJIO]

Example WM_DEVICECHANGE

[abaddon7734]

Some might say it's not foolproof because it relies on WMI being enabled on the target system (which is the default, but can be disabled).

! Is there any way to test if wmi is enabled and working?

Thanks, your UDF is cool!

[abaddon7734]

@wakillon Ah! Stdout and Pid! No more garbage output!

@careca Its not working? What is your OS and is wmic enabled and working in your system? And tried the code posted by wakillon ?

[wraithdu]

Is there any way to test if wmi is enabled and working?

I believe you can check the state of the 'Windows Management Instrumentation' (Winmgmt) service.

[guinness]

Search "is service running".

[careca]

@careca Its not working? What is your OS and is wmic enabled and working in your system? And tried the code posted by wakillon ?

No, Win7 x64, Yes and Yes, Tested it again right now, and it shows all disks as external and a usb pen doesn't appear.

Edited March 19, 2013 by careca

[BrewManNH]

This shows my second internal hard drive and a USB hard drive as external.

@careca

This function isn't designed to detect thumb drives, only external hard drives.

[abaddon7734]

This shows my second internal hard drive and a USB hard drive as external.

This is exactly what i was afraid of! This script is working for system with single Hard drive.

An output of

RunWait(@ComSpec & " /c " & 'wmic diskdrive get PNPDeviceID, size /format:csv | find /v "USBSTOR" > wmic.txt', @ScriptDir, @SW_HIDE)

will yield output like:

Node,PNPDeviceID,Size
X-7068F8D674B94,IDE\DISKST500DM002-1BD142_______________________KC44____\5&2BEE401B&0&0.0.0,500105249280

from which we have to get the size part: 500105249280

But assuming there is a second internal hard drive, output will be like:

Node,PNPDeviceID,Size
X-7068F8D674B94,IDE\DISKST500DM002-1BD142_______________________KC44____\5&2BEE401B&0&0.0.0,500105249280
X-7068F8D674B94,IDE\DISKST500DM002-1BD142_______________________KC44____\5&2BEE401B&0&0.0.0,1000194048000

from which we will have to get 500105249280 + 1000194048000

Hmmmm

[careca]

Yeah, i have 5 internal hdds and all show as external.